Repository navigation
Conversation
…me attributes (pythongh-159269) Setting __name__, __qualname__, __doc__ or __module__ on a function stopped the world in the free-threaded build since pythongh-154826 and pythongh-154851, making functools.wraps() orders of magnitude slower with multiple threads. Use the per-object critical section and _PyObject_XSetRefDelayed() instead, as gen_set_name() already does. Use acquire loads in the readers and hold strong references across error reporting, tracing, and eval-frame recording that may execute Python or detach the thread. The __code__, __defaults__, __kwdefaults__ and __closure__ setters still stop the world to clear func_version. Document synchronization requirements for direct field access and the lifetime of borrowed function attributes. (cherry picked from commit 010bebb) Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
Documentation build overview
329 files changed ·
|
Resolve the committed conflicts using the 3.14 implementations and add the missing _PyObject_XSetRefDelayed helper with its GIL-build fallback. Move the tracing changes into ceval.c and remove the accidentally imported main-branch ceval.h. Keep the recorded function name alive while PyList_Append acquires its lock. Add coverage for recording contention, tracing during attribute replacement, and reentrant annotation finalizers.
nascheme
marked this pull request as ready for review
October 29, 2026 17:17
nascheme
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @nascheme for commit c866403 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159726%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting name, qualname, doc or module on a function stopped the world in the free-threaded build since gh-154826 and gh-154851, making functools.wraps() orders of magnitude slower with multiple threads.
Use the per-object critical section and _PyObject_XSetRefDelayed() instead, as gen_set_name() already does. Use acquire loads in the readers and hold strong references across error reporting, tracing, and eval-frame recording that may execute Python or detach the thread. The code, defaults, kwdefaults and closure setters still stop the world to clear func_version.
Document synchronization requirements for direct field access and the lifetime of borrowed function attributes.
(cherry picked from commit 010bebb)
__name__/__doc__stops the world;functools.wrapsfrom multiple threads is orders of magnitude slower since 3.14.7 #159136